pdm/stream_deck_notion_timer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

v1.0.46: clear stale running-timer state even when stopTimer fails in Notion

Browse Source 
The onKeyDown stop/switch paths only cleared memRunningActionId/EntryId
after a successful stopTimer call. If the tracked Notion entry was
already gone (archived/deleted/edited outside the plugin), stopTimer
threw and the stale ID was never cleared -- every subsequent keypress
retried the same doomed stop call, showed a warning triangle, and the
deck got permanently stuck (unable to unselect the stuck button or
start any new timer). checkElapsed already handled this correctly by
clearing state unconditionally; onKeyDown now does the same: stopTimer
failures are logged but non-fatal, and local state clears regardless.
This commit is contained in:
pdmarf
2026-09-02 11:16:24 +01:00
parent e897f0a8f5
commit 5b3ba8186c
5 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugin.ts
+15 -3
View File
@@ -1,4 +1,4 @@
const CURRENT_VERSION = "1.0.45";
const CURRENT_VERSION = "1.0.46";
const GITEA_BASE = "https://gitea.pdmarf.co.uk/pdm/stream_deck_notion_timer/raw/branch/stable-rebuild";
const SIGNING_PUBLIC_KEY = `-----BEGIN PUBLIC KEY-----
MCowBQYDK2VwAyEAN7ko8TUpuPzPAJuKAZCRjV0c4ZSlou5d9pUAF6o12b4=
@@ -286,13 +286,25 @@ class TimerToggle extends SingletonAction<TimerSettings> {
try {
if (isRunning) {
await stopTimer(global.notionToken, memRunningEntryId!);
// Stopping the entry in Notion is best-effort: if the page is already
// gone/archived (e.g. edited outside the plugin) this throws, but the
// local "running" tracking must clear anyway or every future keypress
// retries this same doomed stop call and the deck gets stuck forever.
try {
await stopTimer(global.notionToken, memRunningEntryId!);
} catch (err) {
streamDeck.logger.error("Failed to stop timer in Notion (clearing local state anyway):", err);
}
setRunningEntry(null, null);
this.clearElapsedCheck();
await Promise.all([ev.action.setState(0), ev.action.setTitle(title)]);
} else {
if (memRunningEntryId) {
await stopTimer(global.notionToken, memRunningEntryId);
try {
await stopTimer(global.notionToken, memRunningEntryId);
} catch (err) {
streamDeck.logger.error("Failed to stop previous timer in Notion (clearing local state anyway):", err);
}
setRunningEntry(null, null);
this.clearElapsedCheck();
}