Compare commits

...
2 Commits
Author SHA1 Message Date
pdmarf e897f0a8f5 v1.0.45: delay blocked-press icon correction to avoid native flash collision
Diagnosed via instrumented logging: the v1.0.44 blocked-press redraw
was calling setState()/setTitle() successfully (no error, confirmed
in logs) but Stream Deck wasn't visually applying it — the corrective
image call was landing too close to Stream Deck's own native
key-press flash animation and getting silently dropped. Forcing a
page navigation away and back always redrew correctly, proving the
tracked state was right all along and this was purely a rendering
timing issue. Adding a 150ms delay before the corrective redraw lets
the native animation settle first; confirmed fixed on device.
2026-08-25 16:52:32 +01:00
pdmarf 2e2f2553ac v1.0.44: clear tracked running state immediately after stopping old timer
Found while testing v1.0.43's icon self-heal: when switching from one
running timer to another, the old Notion entry was stopped but
memRunningActionId/EntryId weren't cleared until AFTER the new
startTimer call resolved. During that gap, a blocked press on the
just-stopped button read the stale (not-yet-cleared) tracked id and
self-healed itself back to a wrongly-'running' green — reinforcing
the exact staleness the self-heal was meant to fix. Now cleared to
null the moment the old timer is actually stopped.
2026-08-25 16:34:38 +01:00
4 changed files with 11 additions and 7 deletions
+3 -1
View File
@@ -6438,7 +6438,7 @@ async function stopTimer(token, entryId) {
} }
// src/plugin.ts // src/plugin.ts
var CURRENT_VERSION = "1.0.43"; var CURRENT_VERSION = "1.0.45";
var GITEA_BASE = "https://gitea.pdmarf.co.uk/pdm/stream_deck_notion_timer/raw/branch/stable-rebuild"; var GITEA_BASE = "https://gitea.pdmarf.co.uk/pdm/stream_deck_notion_timer/raw/branch/stable-rebuild";
var SIGNING_PUBLIC_KEY = `-----BEGIN PUBLIC KEY----- var SIGNING_PUBLIC_KEY = `-----BEGIN PUBLIC KEY-----
MCowBQYDK2VwAyEAN7ko8TUpuPzPAJuKAZCRjV0c4ZSlou5d9pUAF6o12b4= MCowBQYDK2VwAyEAN7ko8TUpuPzPAJuKAZCRjV0c4ZSlou5d9pUAF6o12b4=
@@ -6640,6 +6640,7 @@ var TimerToggle = class extends SingletonAction {
if (this.keyDownBusy) { if (this.keyDownBusy) {
const title = buttonTitle(ev.payload.settings.projectName || ""); const title = buttonTitle(ev.payload.settings.projectName || "");
const shouldBeRunning = memRunningActionId === ev.action.id; const shouldBeRunning = memRunningActionId === ev.action.id;
await new Promise((resolve) => setTimeout(resolve, 150));
await Promise.all([ await Promise.all([
ev.action.setState(shouldBeRunning ? 1 : 0), ev.action.setState(shouldBeRunning ? 1 : 0),
ev.action.setTitle(shouldBeRunning ? `\u23F1 ${title}` : title) ev.action.setTitle(shouldBeRunning ? `\u23F1 ${title}` : title)
@@ -6683,6 +6684,7 @@ var TimerToggle = class extends SingletonAction {
} else { } else {
if (memRunningEntryId) { if (memRunningEntryId) {
await stopTimer(global.notionToken, memRunningEntryId); await stopTimer(global.notionToken, memRunningEntryId);
setRunningEntry(null, null);
this.clearElapsedCheck(); this.clearElapsedCheck();
} }
const entryId = await startTimer(global.notionToken, global.timingDbId, projectId, projectName, global.userId); const entryId = await startTimer(global.notionToken, global.timingDbId, projectId, projectName, global.userId);
@@ -1,3 +1 @@
íü„«ÚƒJºh^©A׊[ÈÍ 696’``w¾)G¶"éoÛ£šAyÍ‹xìØ“ÁÞ ¶á„ÙdG»Cv+t9ãXÅ­ü]M>IÁ¨Í–¼š²ßÁ
Ìg»Jµmã
SÙ¹mš']ï´y�j$¬<ÎÇÙÃ5ef «?eó=™y–
+6 -2
View File
@@ -1,4 +1,4 @@
const CURRENT_VERSION = "1.0.43"; const CURRENT_VERSION = "1.0.45";
const GITEA_BASE = "https://gitea.pdmarf.co.uk/pdm/stream_deck_notion_timer/raw/branch/stable-rebuild"; const GITEA_BASE = "https://gitea.pdmarf.co.uk/pdm/stream_deck_notion_timer/raw/branch/stable-rebuild";
const SIGNING_PUBLIC_KEY = `-----BEGIN PUBLIC KEY----- const SIGNING_PUBLIC_KEY = `-----BEGIN PUBLIC KEY-----
MCowBQYDK2VwAyEAN7ko8TUpuPzPAJuKAZCRjV0c4ZSlou5d9pUAF6o12b4= MCowBQYDK2VwAyEAN7ko8TUpuPzPAJuKAZCRjV0c4ZSlou5d9pUAF6o12b4=
@@ -246,9 +246,12 @@ class TimerToggle extends SingletonAction<TimerSettings> {
if (this.keyDownBusy) { if (this.keyDownBusy) {
// Blocked press: redraw THIS button to match known truth instead of leaving // Blocked press: redraw THIS button to match known truth instead of leaving
// whatever it was already showing (which can be stale from an out-of-band // whatever it was already showing (which can be stale from an out-of-band
// Notion edit) — a pure visual correction, no Notion calls. // Notion edit) — a pure visual correction, no Notion calls. Delayed slightly
// because redrawing immediately can collide with Stream Deck's own native
// key-press flash animation and get silently dropped.
const title = buttonTitle(ev.payload.settings.projectName || ""); const title = buttonTitle(ev.payload.settings.projectName || "");
const shouldBeRunning = memRunningActionId === ev.action.id; const shouldBeRunning = memRunningActionId === ev.action.id;
await new Promise((resolve) => setTimeout(resolve, 150));
await Promise.all([ await Promise.all([
ev.action.setState(shouldBeRunning ? 1 : 0), ev.action.setState(shouldBeRunning ? 1 : 0),
ev.action.setTitle(shouldBeRunning ? `⏱ ${title}` : title), ev.action.setTitle(shouldBeRunning ? `⏱ ${title}` : title),
@@ -290,6 +293,7 @@ class TimerToggle extends SingletonAction<TimerSettings> {
} else { } else {
if (memRunningEntryId) { if (memRunningEntryId) {
await stopTimer(global.notionToken, memRunningEntryId); await stopTimer(global.notionToken, memRunningEntryId);
setRunningEntry(null, null);
this.clearElapsedCheck(); this.clearElapsedCheck();
} }
const entryId = await startTimer(global.notionToken, global.timingDbId, projectId, projectName, global.userId); const entryId = await startTimer(global.notionToken, global.timingDbId, projectId, projectName, global.userId);
+1 -1
View File
@@ -1 +1 @@
{ "version": "1.0.43" } { "version": "1.0.45" }